search

bahmutov / cypress-svelte-unit-test

Unit testing Svelte components in Cypress E2E test runner
162 stars 21 forks source link

wait for css files to load before returning the svelte instance #253

Closed JohnnyFun closed 3 years ago

JohnnyFun commented 3 years ago

fixes https://github.com/bahmutov/cypress-svelte-unit-test/issues/250

JohnnyFun commented 3 years ago

I didn't test this manually very much. Relying on the repo's tests to let me know if I messed anything up...

JohnnyFun commented 3 years ago

Ideally a test would be added that asserts cssFile option works. But gotta sleep...

alejandroiglesias commented 3 years ago

@bahmutov did you have a chance to look at this? It would unblock some test specs for me as I described in #250.

JohnnyFun commented 3 years ago

Sure, I bet I can add one to this spec and just assert that $set exists on the resolved object: https://github.com/bahmutov/cypress-svelte-unit-test/blob/master/cypress/components/styles/styles-spec.js

JohnnyFun commented 3 years ago

Ok, I added a test and confirmed it breaks without my change and passes with it.

JohnnyFun commented 3 years ago

Ok, looks like all tests pass--I had not yet pushed when I made my previous comment, so apologies if that caused any confusion.

bahmutov commented 3 years ago

Super, thank you very, much, merging now

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 3.3.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: