search

bahmutov / eslint-rules

My custom eslint rules in addition to the ones provided at http://eslint.org/
97 stars 16 forks source link

fix(console.assert): console.assert polyfill #15

Closed brekk closed 7 years ago

brekk commented 7 years ago

Hey Gleb,

I love this plugin generally, but have had an issue running it within Atom.

screen shot 2017-07-01 at 8 37 02 am

I was able to fix the errors locally by adding the console-assert package (per the linked thread).

Additionally, I was seeing a test fail on commit pre-hook:

/eslint-rules/test/long-file.js
  0:0  warning  file line count 110 exceeded line limit 100  no-long-files

But I didn't touch that file so I wasn't sure what to do there.

Please let me know if there's anything else you need.

Thanks,

Brekk

bahmutov commented 7 years ago

cool, cool, thank you very much, hope it works!