search

bahmutov / local-cypress

Use Cypress without global objects
https://glebbahmutov.com/blog/local-cypress/
33 stars 3 forks source link

Update from EventEmitter to CyEventEmitter (+cypress@9.7.0) #67

Closed merrywhether closed 2 years ago

merrywhether commented 2 years ago

Cypress types were updated in a PR included in the 9.7.0 release, changing EventEmitter to CyEventEmitter. This PR updates to 9.7.0 and fixes the types accordingly.

It also winds up updating package-lock.json from v1 to v2 as the latest npm longer supports v1. This update is forced by simply running npm i with npm@8.5.0. I'm not sure how to work around this will updating the Cypress dependency version and keeping the lockfile in sync, but I imagine other contributors would run into this as well. Let me know if this is a problem.

peterkrieg commented 2 years ago

Thanks for putting this together @merrywhether . I was having the same problem. I tested this out and the minor types change seems to also work with cypress 10 👍

dvargas92495 commented 2 years ago

@bahmutov anything we could do to help get this PR over the finish line? Bug is affecting me too on cypress 10.1

peterkrieg commented 2 years ago

In case it helps someone else until this PR ships, I have a hosted version of the fixes, and you just need to put the following in your package.json file:

"local-cypress": "https://github.com/peterkrieg/local-cypress/archive/refs/tags/v1.2.7.tar.gz",
bahmutov commented 2 years ago

Super, let me merge and release

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.2.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: