search

bahmutov / now-pipeline

Simple CI pipeline with goal to deploy new version at Zeit Now cloud if tests pass
141 stars 8 forks source link

Add list of optional filenames to the check. #28

Closed wulfmann closed 6 years ago

wulfmann commented 6 years ago

Right now the list is hardcoded, I am going to add another PR later to allow this to overridden by parameters if that seems like a good idea, but this should fix the issue we've been having.

Even though this change is extremely simple, it's a little hard to test. here's a bin showing it will function as expected:

http://jsbin.com/buhahasazo/edit?js,console

bahmutov commented 6 years ago

Love it, thank you for taking time to make this change. Let me see if I can release it quickly

wulfmann commented 6 years ago

No trouble at all, thanks for merging so quickly! I'm working on recreating my own issue from earlier this year, but i've mentioned to the latest dev with the issue that the package will be updating and to let us know if it solved his issue. I don't think it will require anything more than the above, but you never know.

Thanks again for being so speedy.