bahmutov / now-pipeline

Simple CI pipeline with goal to deploy new version at Zeit Now cloud if tests pass
141 stars 8 forks source link

add option for custom directory and update readme #29

Closed wulfmann closed 6 years ago

wulfmann commented 6 years ago

Let me know what you think of this implementation.

All it requires is checking if --dir was added with the command, and if it is, it uses that directory as the target directory.

This requires the package.json to also be in that directory, but that seems to be the desired behavior.

Just want to make sure i'm not misunderstanding the flow of the program in any way. Completely open to suggestions.

bahmutov commented 6 years ago

a few notes

wulfmann commented 6 years ago

Great points all around, I made those changes.