search

bahmutov / npm-install

GitHub Action for install npm dependencies with caching without any configuration
https://github.com/marketplace/actions/npm-or-yarn-install-with-caching
650 stars 70 forks source link

Work around cache module modifying input paths #188

Closed Bertg closed 1 year ago

Bertg commented 1 year ago

An issue in action/toolkit modifies the inputPath values passed to cache function. These changes work around this issue.

For more details see: https://github.com/actions/toolkit/pull/1378

This resolves #175

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.8.33 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

oleksandr-danylchenko commented 1 year ago

@Bertg, thank you so much!

oleksandr-danylchenko commented 1 year ago

Are there any dates on when the version bump in the GitHub Actions marketplace is planned for? Seems like it's still using the 1.6.0 version, instead of the latest 1.8.33 image

bahmutov commented 1 year ago

@oleksandr-danylchenko the version displayed on GitHub Actions marketplace does not matter, you still pick the version you want to use. I should find out if there is an automatic way to update the marketplace version

oleksandr-danylchenko commented 1 year ago

Thanks 👌🏻 I manually picked the 1.8.33 version in the action. Just wondering about the marketplace to be able to use the latest version automatically just with @1

Bertg commented 1 year ago

@oleksandr-danylchenko We use the @1 notion in our workflows. And we are seeing cache hits again. So I'm fairly certain it just works, and there is a disconnect between the marketplace displayed version, and the actual version resolution in the GitHub actions.

Bertg commented 1 year ago

@bahmutov If you still are looking into the issue, as to why the version in marketplace is lagging, here are the docs: https://docs.github.com/en/actions/creating-actions/publishing-actions-in-github-marketplace

It may have something to do with accepting the "GitHub Marketplace Developer Agreement", which is something that is new to me, and maybe to you as well?