] - Githubissues

bahmutov / pre-git

Automatically install pre-commit / pre-push hooks in your git repo

168 stars 22 forks source link

Closed orgjscom closed 8 years ago

orgjscom commented 8 years ago

]

bahmutov commented 8 years ago

So this situation happens when

you pull new project from remote repo
try to commit right away
the hook in .git folder tries to use ./node_modules/... but the pre-git module has not been installed yet

bahmutov commented 8 years ago

One just needs to put hooks from this projects into fresh git repo's .git folder to test this

bahmutov commented 8 years ago

Best way to recreate the problem

clone this repo and run npm install
execute npm run e2e which goes through the script test/e2e.sh and creates a new test folder inside /tmp/test-pre-git folder
cd /tmp/test-pre-git folder and remove node_modules folder
try making an empty commit git commit --allow-empty -m "test" you should see the problem - tries to use node modules folder and fails

.git/hooks/pre-commit: line 3: ./node_modules/.bin/pre-commit: No such file or directory

bahmutov commented 8 years ago

Would you like to implement this and add to all hook files and submit a pull request? Will gladly accept it!