search

bahmutov / pre-git

Automatically install pre-commit / pre-push hooks in your git repo
168 stars 22 forks source link

Tests fail with pre-commit still allows commit to pass #90

Closed asavin closed 8 years ago

asavin commented 8 years ago

This might not be an issue with pre-git, but somehow when I run npm test as part of pre-commit hook (defined in package.json) and tests fail, commit is still allowed to pass through.

alex_badgeras____red-badger_website-next-2_website-next__zsh_

My pre-git config part of package.json looks like this:

 "config": {
    "pre-git": {
      "pre-commit": [
        "npm t"
      ],
      "pre-push": [],
      "post-commit": [],
      "post-checkout": [],
      "post-merge": []
    }
  }
bahmutov commented 8 years ago

hmm, that should not happen. Can I ask which version of pre-git you are rocking?

asavin commented 8 years ago

It's 3.9.0

bahmutov commented 8 years ago

Will investigate, thank you for opening an issue

asavin commented 8 years ago

That was quick, thanks! All work now.