search

bahnzumberg / zuugle-suchseite

Public repository for www.zuugle.at
https://www.zuugle.at
GNU General Public License v3.0
6 stars 11 forks source link

Google PageSpeed Insights #182

Closed martinheppner closed 2 months ago

martinheppner commented 1 year ago

The UAT branch (https://github.com/bahnzumberg/zuugle-suchseite/tree/uat) should be optimzed so the overall performance gauge is green for mobile and desktop (https://pagespeed.web.dev/) testing www2.zuugle.at.

Second the build process is not compaining about "exceeding file limits" anymore - see screenshot below.

##################

Current results https://pagespeed.web.dev/analysis/https-www2-zuugle-at/qvbwha9eoz?form_factor=mobile image image

Screenshot of "npm run build" result image

martinheppner commented 1 year ago

To install follow the instructions:

  1. Backend: https://github.com/bahnzumberg/zuugle-api#zuugle-api
  2. Frontend: https://github.com/bahnzumberg/zuugle-suchseite#zuugle-suchseite

If you want to run only the frontend with the use of the backend remotely, you can use npm run start-remote-api

martinheppner commented 2 months ago

Image

martinheppner commented 2 months ago

Please see to it, that you only clone the branch UAT. Whenever you want to test it, create a pull request and I will commit it, so it it deployed to www2.zuugle.at, where you can test it.

We are working on the app as well, so it makes sense, that you sync frequently. I will create now a branch called shiv on frontend and on api, so we can easily compare, if everything that was working before this gig, is still working, when you are finished.

martinheppner commented 2 months ago

Fiverr order number #FO519253AA183

martinheppner commented 2 months ago

After optimization in the backend:

Startpage: https://www2.zuugle.at Image

Searchresults: https://www2.zuugle.at/search Image

Searchresults with city: https://www2.zuugle.at/search?city=wien Image

Single Result: https://www2.zuugle.at/tour/116054/wien Image

martinheppner commented 2 months ago

App.js : Import of start.js is not lazy import anymore. Normal one. Matomo: changed key from 'event' to event. Changed a few " to ' Rest of what looks like changes is only formatting

File: Header Formatting of imports Removed "useResponsive" instead of using this function he set the const isMobile to be always true, so now the preloadUrl takes only the Mobil image. He removed the loading condition from JSX rendering of header He re-ordered logic for rendering of  header text.

File : Search Formatting of imports Removed "capitalize" which is a lodash package import and replaced it with a JS function. Removed 2 props for filter : "filterOn" and setFilterOn. Removed condition of existing data in "importedMarkersArray" Removed a useEffect I had done that uses the state "filterOn" he removed above So now 2 things happen (check UAT): When map is on the filter form does not work properly. Also the background scrolling is still there , something related to freezing background when filter form is open. He switched a translation from dein_heimatbahnhof to just heimatbahnhof

He changed some jsx , like order of SearchIcon and TransportTrain icon.

Added unused loading functions like load FavouriteTours ( I think we independently cleaned up these last week)