search

bahobab / colmar-academy

flexbox showcase
0 stars 0 forks source link

background image vs image tag #4

Open rimmesbe opened 6 years ago

rimmesbe commented 6 years ago

The problem with using background images here is that it is going to be hard to maintain the images natural ratio. Your mobile images are to blocky because of this. The general rule of thumb for background-image verse image tag is "is this image content?". In this case I think it is content.

https://github.com/bahobab/colmar-academy/blob/master/resources/css/style.css#L291-L301

bahobab commented 6 years ago

Great point rimmesbe. I'm looking for solutions to refactor this implementation...