search

bahriddin / ckeditor-html5-video

HTML5 video plugin for CKEditor
GNU General Public License v3.0
37 stars 36 forks source link

Support for Drupal integration #3

Open EelcoPeacs opened 7 years ago

EelcoPeacs commented 7 years ago

Hi Bahriddin,

Great work. After looking into the potential video plugins for the CKEditor, I found yours most fitting to the functionality I require for a Drupal installation. Unfortunately integrating two systems isn't always straitforward and I ran into some problems. After writing a simple Drupal module to integrate the html5video plugin and enabling it through the Drupal inteface, the button didn't show up on the CKEditor toolbar. I found out that the widgets "button:" property isn't correctly supported/handled. Attached is a patch for the adjusted code which does bring the button to the toolbar in Drupal and doesn't break the functionality in a CKEditor setting. Part of it is that I renamed the edit dialog to include the word 'Dialog'. This isn't required, but it took me some time to get the difference between html5video and html5video. If you agree, I can push it to the server, or you can apply the patch if you want. I will continue my development for the Drupal module, so there may come more.

Regards, Eelco

ckeditor-html5-video-1.patch

bahriddin commented 7 years ago

Dear EelcoPeacs, I have so appreciated your contribution. It is amazing))) Now I am not in suitable place to check. I do reply you a.s.a.p. BTW, thanks a lot!

EelcoPeacs commented 7 years ago

Hi Bahriddin, Thanks for the quick response, but don't rush. I just setup a CKEditor environment next to the Drupal environment and tested my changes and the patch isn't finished yet. Some thing s fail to work due to my changes. I'm still working it. Meanwhile I created a fork for the repository and am working in that one. Let's keep this issue open to discuss progress.

bahriddin commented 7 years ago

Ok, sure I am happy to work together!

bahriddin commented 7 years ago

Hi, @EelcoPeacs. Any news?

EelcoPeacs commented 7 years ago

Hi bahriddin, Unfortunately no progress yet. I got a bit distracted by my other projects. But there is some development. I have a talk in September regarding a project I would like to start where this development must be part of. I still want to proceed with this as it is a good starting point to integrate the video plugin into Drupal which will be beneficial for both the CKeditor and Drupal communities. I'll keep you posted.

bahriddin commented 7 years ago

Thank you, @EelcoPeacs. Currently, I am working with the project where I used this plugin. So I will update my knowledge about CKEditor and hope to add some new features. Regards.