bahrmichael / factorio-tycoon

GNU General Public License v3.0
8 stars 6 forks source link

fix: make crowdin script darwin compatible #286

Closed bahrmichael closed 4 months ago

bahrmichael commented 4 months ago

When I run this on darwin, it looks like the locale part is duplicated:

ERROR: File does not exist: locale/locale/de/controls.cfg
ERROR: File does not exist: locale/locale/ja/controls.cfg
ERROR: File does not exist: locale/locale/pt-BR/controls.cfg
...

Note that I changed --tempdir to -t because the former is not supported on darwin, and I think -t is the equivalent maybe?

Without that changed here's what I see:

...
./scripts/compare_locales.sh: line 48: : No such file or directory
ERROR: Unable to extract from: locale/en/tips-and-tricks-item-description.cfg
mktemp: illegal option -- -
usage: mktemp [-d] [-q] [-t prefix] [-u] template ...
       mktemp [-d] [-q] [-u] -t prefix 
...
winex commented 4 months ago

@bahrmichael you missed removing of $base_dir/ in https://github.com/bahrmichael/factorio-tycoon/blob/3cccd43f6b2daecccc1e3f58cce753c4700df1ed/scripts/compare_locales.sh#L55-L59

mktemp

p.s. nobody knows what Darwin is (except for us), but knows what MacOS is, lol

bahrmichael commented 4 months ago

Right! Thanks :) It works as expected now