search

bahrmichael / factorio-tycoon

GNU General Public License v3.0
8 stars 6 forks source link

chore: reduce arguments and couple of new functions #307

Closed winex closed 3 months ago

winex commented 3 months ago

picked these short and clean commits from destruction handling, so anything can be reverted easily

i know that {y = 0, x = 0} should be the same as {x=, y=}, but Factorio says it tries to keep order of insertion (don't remember for what exactly, though). so it seems wrong if something would try to access it as coords[1], coords[2] which is allowed for MapPosition type

i have 2 more commits, adding allowCenter in addBuildingLocations(), but i couldn't test if it works, yet edit: yes, these are needed for rebuilding after destroy event

winex commented 3 months ago

if everything looks good, i'd prefer this not to be squashed. thank you!

winex commented 3 months ago

i confirm that 2 last commits are needed for future destroy event handling this is ready to be merged! don't squash please, thanks!

bahrmichael commented 3 months ago

GitHub had a hiccup. The changes were rebased onto main.