Closed logaretm closed 5 years ago
Merging #27 into master will decrease coverage by
0.33%
. The diff coverage is43.33%
.
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 31.56% 31.23% -0.34%
==========================================
Files 6 6
Lines 415 429 +14
Branches 68 73 +5
==========================================
+ Hits 131 134 +3
- Misses 273 284 +11
Partials 11 11
Impacted Files | Coverage Δ | |
---|---|---|
src/store.js | 61.11% <33.33%> (ø) |
:arrow_up: |
src/components/Verte.vue | 30.61% <44.44%> (-1.54%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0f9922d...fad914a. Read the comment docs.
Can the version number be bumped so I can update npm to try this?
Side note: since the API seems to be changing more rapidly than the docs, could a release notes or version history be added to the README.md so that developers can see what changing when they update? Thanks.
This PR introduces a couple of breaking changes and major enhancement to the color-history API.
Breaking Changes
recentColors
prop as it tried to do way too many things.as a replacement, two new props have been added:
showHistory
prop to control the recent colors list visibility.colorHistory
prop which is used to provide a list of colors.New Features
20 Disabled the ability to provide shareable colors after the app is bootstrapped, which prevents lazy components or dynamic ones from specifying the recent colors.
The new
colorHistory
prop allows the user to pass an array of color strings which will be used as the source of the history, the internal store implemented in #20 will be ignored and local data will be used to control the recent colors. This means all verte components passingcolorHistory
will be isolated and will not share the same colors.The use of
.sync
modifier will solve this problem:This allows the developer to be able to maintain and control the recent colors as they see fit.
The docs have been updated to reflect those changes.
closes #26