search

baianat / verte

🎨 A Color picker component. Built from the bottom to work with Vue.js.
https://baianat.github.io/verte/
MIT License
181 stars 42 forks source link

Make classname more specific #61

Closed ghost closed 2 years ago

ghost commented 4 years ago

We should change the classname of slider to something more specific, like verte__slider. The problem is, that the verte css (or the css of other dependencies) will break the layout, which happened in my project for example

codecov[bot] commented 4 years ago

Codecov Report

Merging #61 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   31.23%   31.23%           
=======================================
  Files           6        6           
  Lines         429      429           
  Branches       73       73           
=======================================
  Hits          134      134           
  Misses        284      284           
  Partials       11       11
Impacted Files Coverage Δ
src/components/Slider.vue 27.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7bf7d6a...1cf1c63. Read the comment docs.