search

baidu-research / DeepBench

Benchmarking Deep Learning operations on different hardware
Apache License 2.0
1.07k stars 239 forks source link

MKL: conv: remove unused headers #57

Closed rsdubtso closed 7 years ago

sharannarang commented 7 years ago

@rsdubtso , could you please also remove these files?

https://github.com/baidu-research/DeepBench/blob/master/code/intel/gemm/input.h https://github.com/baidu-research/DeepBench/blob/master/code/intel/sgemm/input.h

I think these files are still being used. It'll be great if you could update the code and get rid of them. Thanks!

rsdubtso commented 7 years ago

Sure, will look into this.

efeguney commented 7 years ago

@rsdubtso @sharannarang , I will update the GEMM code and share common header files. In addition, sgemm folder can be removed now.

efeguney commented 7 years ago

@sharannarang , PR#61 removes input.h dependency from Intel GEMM components.

sharannarang commented 7 years ago

Thanks @rsdubtso and @efeguney . Merging this PR.