search

baidu-research / warp-ctc

Fast parallel CTC.
Apache License 2.0
4.07k stars 1.04k forks source link

Add Rocm support #168

Closed windstamp closed 3 years ago

windstamp commented 3 years ago

Add ROCm support for warp-ctc.

windstamp commented 3 years ago

这里hiprand_LIBRARY_DIRS的定义，确认在hip.cmake里面能找到

确认是能找到的，如下：

(base) windstamp@rocm35:/opt/rocm/hiprand/lib/cmake/hiprand ls
hiprand-config.cmake  hiprand-config-version.cmake  hiprand-targets.cmake  hiprand-targets-release.cmake
(base) windstamp@rocm35:/opt/rocm/hiprand/lib/cmake/hiprand grep hiprand_LIBRARY_DIRS -r *
hiprand-config.cmake:#   hiprand_LIBRARY_DIRS     - Link directory for hipRAND library.
hiprand-config.cmake:set_and_check(hiprand_LIBRARY_DIRS "${PACKAGE_PREFIX_DIR}/hiprand/lib" )
windstamp commented 3 years ago

多余不需要的库删掉

done, thanks.

windstamp commented 3 years ago

这里不需要改成hip_add_executable，正常.cpp或者.cc结尾的文件用add_executable就可以了

done, thanks.

windstamp commented 3 years ago

这里把CUstream命名为GPUstream会更加合适一点，因为typedef struct CUstream_st* CUstream;是CUDA本身的一个定义，以防万一和这个头文件被其他文件include之前或者之后引用了cuda的头文件，会导致这个定义失效，最好定义成GPUstream就可以避免这个问题。

done, thanks.