license for contributions

jlovejoy commented 6 years ago

Can you confirm that contributions to your project are accepted under Apache-2.0?

thank you.

mingyux commented 6 years ago

@jlovejoy Thanks for bringing up this issue. Since this repo is hosted under Baidu, the company requires the contributors to e-sign CLA (Contributor License Agreement). We have updated the CLA binding to Github so it will pop up before making PR.

jlovejoy commented 6 years ago

thanks @mingyux - but there is still no (obvious) way to review the CLA before someone is presented with signing it. Could you put a copy in your directory or a link to where one can review it?

mingyux commented 6 years ago

@jlovejoy We've updated the README by adding a section for Contribution, which includes a link to the CLA for review.

jlovejoy commented 6 years ago

Thanks! looks like this is based on the individual Apache CLA, and... (sorry to ask another question...) there is also a corporate version of that which is referenced in the version you have here - I think we need to sign the corporate version, unless you are not using that too?

mingyux commented 6 years ago

The CLA linked to Github is the I-CLA. For corporation CLA, please contact Weiling at zhangweiling01@baidu.com.

jlovejoy commented 5 years ago

Hi again, I hate to be a bother, but I have not gotten a response from Weiling. In the meantime, I reviewed your individual CLA (since it seems that all contributors will have to sign that, even if their employer also signs a corporate CLA) and it seem like maybe the terms got confused a bit:

“Baidu” is defined in the first sentence as “open source projects” – this doesn’t make sense in several places later in the agreement where “Baidu” seems to clearly be referring to the company, most notably in the license grants in section 2 and 3
“contributions is defined in the first paragraph and then again in the definitions section – there should only be one definition
“Projects” is a capitalized term in the first paragraph, yet not defined and not used again
“Work” is defined as “any of the products owned or managed by Baidu” – this is too far-reaching for a company. It seems like Work should mean “open source projects”, but as mentioned above, you have that definition for “Baidu”

We would really like to contribute to your project, do you think you can help clarify the above issues?

Thanks

mingyux commented 5 years ago

@jlovejoy Would you mind sending me an email with your company email? I'll try to involve more people from Baidu to get on this issue.

mingyux commented 5 years ago

@jlovejoy Please send email to zhangweiling01@baidu.com again and cc chenmingyu01@baidu.com as it may be blocked by the system.

jlovejoy commented 5 years ago

will do, thanks!

mingyux commented 5 years ago

Please leave a message here as well once you emailed us, so I can make sure it is not blocked.

jlovejoy commented 5 years ago

sent and got your response :)

baidu / ICE-BA

license for contributions #9