search

baidu / fast_rgf

Multi-core implementation of Regularized Greedy Forest
MIT License
465 stars 111 forks source link

fix dtree.h apply bug and score degradation #13

Closed fukatani closed 6 years ago

fukatani commented 6 years ago

Current FastRGF led to score degradation in our FastRGF example script. Please see https://github.com/fukatani/rgf_python/pull/152 .

I deleted unnecessary line in dtree.h, score seems improved.

fukatani commented 6 years ago

To verification FastRGF performance, we used https://github.com/fukatani/rgf_python/blob/master/examples/FastRGF/FastRGF_regressor_on_boston_dataset.py . (Current version MSE ~ -6 and This PR fixes MSE to 0.97) You need to install rgf_python or you can confirm score degradation by your own example.