baidu / sofa-pbrpc

A light-weight RPC implement of google protobuf RPC framework.
Other
2.13k stars 655 forks source link

支持用户自定义web请求的处理函数 #50

Closed cyshi closed 8 years ago

cyshi commented 8 years ago

主要改动

功能描述

cyshi commented 8 years ago

@qinzuoyan 有时间辛苦看看这个pr是否ok

qinzuoyan commented 8 years ago

Ok

On Tue, Dec 29, 2015 at 1:50 PM, cyshi notifications@github.com wrote:

@qinzuoyan https://github.com/qinzuoyan 有时间辛苦看看这个pr是否ok

— Reply to this email directly or view it on GitHub https://github.com/baidu/sofa-pbrpc/pull/50#issuecomment-167723289.

qinzuoyan commented 8 years ago

the branch has conflicts, you should first do merge

cyshi commented 8 years ago

好的 一起修改

cyshi commented 8 years ago

辛苦 @qinzuoyan 再看看

bluebore commented 8 years ago

这个现在啥结论?

qinzuoyan commented 8 years ago

@cyshi 这今天我再找时间review一下,整体没啥问题,有些细节需要改进下,估计很快就完工了。不急吧?

cyshi commented 8 years ago

好的 辛苦了

Profiling #64 @qinzuoyan 有时间也可以先看看

qinzuoyan commented 8 years ago

@cyshi , 我发了一些review,你看看?

cyshi commented 8 years ago

好的 我一次改了

qinzuoyan commented 8 years ago

@cyshi , 我先merge了,你后面的fix再发新的pull request吧