search

baijunyao / laravel-bjyblog

Laravel v9 blog
https://baijunyao.com/docs/laravel-bjyblog
MIT License
525 stars 201 forks source link

Article slug #45

Closed khyoz closed 5 years ago

khyoz commented 5 years ago

Article slug for SEO

khyoz commented 5 years ago

not an expert on git with PR yet, can you tell me if that is what you asked by "Can you change the PR target to the develop branch? I will add an upgrade command, thank you."

baijunyao commented 5 years ago

You don't need to open a new PR, you can change the base to develop and compare to your khyoz:article-slug in #44 .

WX20190519-143030@2x
khyoz commented 5 years ago

ok, I tried and now I have a message 'A pull request already exists for base branch 'develop' and head branch 'article-slug'' so I believe I need to close #44 ?

baijunyao commented 5 years ago

Yes