baileyholl / Ars-Nouveau

Repository for the Ars Nouveau minecraft mod. https://www.curseforge.com/minecraft/mc-mods/ars-nouveau
https://www.curseforge.com/minecraft/mc-mods/ars-nouveau
GNU Lesser General Public License v3.0
169 stars 98 forks source link

Ars-reset command requires logout #1300

Closed Ph4i1ur3 closed 3 months ago

Ph4i1ur3 commented 4 months ago

If you try to remove glyphs, or reset your glyphs it does not update until you relog

I think ive tracked it back to the deserialization of the capability sync packet here: https://github.com/baileyholl/Ars-Nouveau/blob/c3e54e0744f3f659fb5df175e61a0155f6959ff2/src/main/java/com/hollingsworth/arsnouveau/common/capability/ANPlayerDataCap.java#L120

Glyphs appear to only be added, making live removal impossible client-side

Ph4i1ur3 commented 4 months ago

I suppose I should add that the same appears to be true for Familiars, however i have not tested that myself