baileyholl / Ars-Nouveau

Repository for the Ars Nouveau minecraft mod. https://www.curseforge.com/minecraft/mc-mods/ars-nouveau
https://www.curseforge.com/minecraft/mc-mods/ars-nouveau
Other
179 stars 108 forks source link

Mycelial Sourcelink uses wrong value in saturation calculation (1.20.1) #1500

Closed Dominus-Sicarum closed 1 week ago

Dominus-Sicarum commented 1 week ago

It calculates mana like this: mana += 30 * food.getSaturationModifier();

instead of plugging in the saturation formula, making gains from saturation miniscule, since modifier is 0.6 for most items.

Dominus-Sicarum commented 6 days ago

I probably should've provided more info on the issue.

Saturation formula in minecraft is: nutrition saturationModifier 2

Neoforge's .saturation() already provides value by that formula (so 1.21 changes were not needed), but in 1.20 saturation is still not what it should be. I made a pull request to illustrate, if that helps? #1506