search

baileyholl / Ars-Nouveau

Repository for the Ars Nouveau minecraft mod. https://www.curseforge.com/minecraft/mc-mods/ars-nouveau
https://www.curseforge.com/minecraft/mc-mods/ars-nouveau
GNU Lesser General Public License v3.0
174 stars 103 forks source link

Whirlisprig.<init> Causes High CPU usage while ending up in java execption #934

Closed UdoMorgenstern closed 1 year ago

UdoMorgenstern commented 1 year ago

Forge: 1.19.2 43.2.8 Ars: v3.13.2

so far unknown how to reproduce, but seen reoccurring on our server

Spark Profiler logs showing issue in Whirlisprig init: image com.hollingsworth.arsnouveau.common.entity.Whirlisprig.()7.29%4 Link to full profiler result https://spark.lucko.me/yA4YFwjjrS

UdoMorgenstern commented 1 year ago

guessing its related to the Constructers calling: if(!level.isClientSide) MinecraftForge.EVENT_BUS.register(this);

which seems to be only the case for the Whirlisprig (probably for good reason)

UdoMorgenstern commented 1 year ago

compared with EntityWixie Call to MinecraftForge.EVENT_BUS.register(this); was removed from EntityWixie constructors with commit "Adds wixie, sylph, bookwyrm functionality" on 08/25/2021 SHA: 350ec747043b1fd5cdae5dd3a324a28db6b04826

Edit: removed calls from Whirlisprig for testing, all seems to work just fine

baileyholl commented 1 year ago

Should be fixed next version (1.19+)