search

bailoo / itrack

Location Tracking for Everyone
3 stars 2 forks source link

libLogNew.php and fulldata_riz.php #48

Closed bailoo closed 9 years ago

bailoo commented 9 years ago

These are very bad filenames! What is libLogNew.php? If you want to use names like old and new then why use git?

Similarly fulldata_riz.php is a bad name. Give it a meaningful name. If you want you can make a dir called example and put various example of reading fulldata in that.

rizcompeer commented 9 years ago

I had only fulldata_riz.php to show i have created this only for testing purpose. There are continuous updations and problems coming using Git and we do not have enough time to wait due to client pressure. We clean it all later. I will raise issue for the problems.

On Mon, Aug 10, 2015 at 2:40 AM, Abhishek Singh Bailoo < notifications@github.com> wrote:

Assigned #48 https://github.com/bailoo/itrack/issues/48 to @rizcompeer https://github.com/rizcompeer.

— Reply to this email directly or view it on GitHub https://github.com/bailoo/itrack/issues/48#event-377473939.

Regards

Rizwan Ahmad Innovative Embedded Systems.Pvt.Ltd.

rizcompeer commented 9 years ago

I have deleted fulldata_riz and in future will make the testing in folders outside of the library.

For other i have to confirm from Parwez. Has he made and using his file anywhere.

On Mon, Aug 10, 2015 at 10:34 AM, Rizwan Ahmad rizwan@iembsys.com wrote:

I had only fulldata_riz.php to show i have created this only for testing purpose. There are continuous updations and problems coming using Git and we do not have enough time to wait due to client pressure. We clean it all later. I will raise issue for the problems.

On Mon, Aug 10, 2015 at 2:40 AM, Abhishek Singh Bailoo < notifications@github.com> wrote:

Assigned #48 https://github.com/bailoo/itrack/issues/48 to @rizcompeer https://github.com/rizcompeer.

— Reply to this email directly or view it on GitHub https://github.com/bailoo/itrack/issues/48#event-377473939.

Regards

Rizwan Ahmad Innovative Embedded Systems.Pvt.Ltd.

Regards

Rizwan Ahmad Innovative Embedded Systems.Pvt.Ltd.

bailoo commented 9 years ago

Ok. Please create a directory called examples and put your use cases of API in that.

Parvez created libLogNew.php. why is new needed?

ashish-iembsys commented 9 years ago

this shud not have been done and is merely a wrong methodology in place. We need to improve the working style of parwez, but it may take some time.

bailoo commented 9 years ago

I have put Rizwan's file in a new directory phpApi/examples

bailoo commented 9 years ago

libLogNew.php deleted.

sparwez commented 9 years ago

Dear Sir, this is really a bad naming style I will take care of next time.

Regards Shams Parwez

On Thu, Aug 13, 2015 at 11:59 PM, Abhishek Singh Bailoo < notifications@github.com> wrote:

Closed #48 https://github.com/bailoo/itrack/issues/48.

— Reply to this email directly or view it on GitHub https://github.com/bailoo/itrack/issues/48#event-381773993.