search

bailuk / AAT

Another Activity Tracker for Android
https://bailu.ch/aat
GNU General Public License v3.0
150 stars 41 forks source link

[minor bug] GPX-File-Format #121

Closed watchingJu closed 2 years ago

watchingJu commented 2 years ago

hey,

I might have found a small bug when writing the GPX-File-Format:

https://github.com/bailuk/AAT/blob/c1fdcc17c07114f4b8ab737cf20aa002be8a8e12/aat-lib/src/main/java/ch/bailu/aat_lib/xml/writer/GpxWriter.java#L56-L58

The result is:

<gpx xmlns="http://www.topografix.com/GPX/1/1"
    creator="AAT Another Activity Tracker v1.21" version="1.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://www.topografix.com/GPX/1/1 http://www.topografix.com/GPX/1/1/gpx.xsd">

But the version should be "1.1" not "1.0" according to the schemeLocation=http://www.topografix.com/GPX/1/1 and the official GPX 1.1 Scheme

<xsd:attribute name="version" type="xsd:string" use="required" fixed="1.1">
<xsd:annotation>
<xsd:documentation>
You must include the version number in your GPX document.
</xsd:documentation>
</xsd:annotation>
</xsd:attribute>

Some external programs might crash or have unwanted behavior when running a check on that version.

Btw thanks for all your work on this app :)