Inform user if offline map file can't be found

bailuk / AAT

Another Activity Tracker for Android

https://bailu.ch/aat

GNU General Public License v3.0

156 stars 41 forks source link

Inform user if offline map file can't be found #133

Closed rparkins999 closed 2 years ago

rparkins999 commented 2 years ago

If the offline map file isn't in the expected place, the user just sees a track with no map underneath it and it isn't apparent what is wrong. This pull request displays a message saying

No map files found at directory

bailuk commented 2 years ago

I've merged this request and made the following adjustments:

Remove obsolete and not allowed quotes (") in string resource
Remove obsolete comment in string resource (all string resources need translation)
Remove comment that does not belong into source code in Configuration.java
Run generate_strings.py (see my review comment)
Import string resource
Block brackets at same line as if and else statement (convention used in this project)

See my changes: https://github.com/bailuk/AAT/commit/bcaacf7fa66813b491671afb9de0fffc949f5a19

rparkins999 commented 2 years ago

I don't know where you got the idea that quotes aren't allowed around a string resource. They certainly are, and are sometimes necessary if the string resource begins or ends with whitespace. I think that if you can mange to provoke the error with your "corrected" version, you will find that there is no space between "at" and the filename. My version puts in the space.

bailuk commented 2 years ago

You are most likely right about that quotes are allowed. The problem here is that my generate_strings.py script can't handle quotes. This is not really a problem as it will respect spaces after string. See resulting java file.