baires / shouldideploy

Source of shouldideploy.today
https://shouldideploy.today/
Do What The F*ck You Want To Public License
384 stars 77 forks source link

Update reasons.ts #1093

Closed Wervice closed 7 months ago

Wervice commented 7 months ago

I added some more reasons why you shouldn't deploy

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
shouldideploy βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 18, 2024 6:38pm
baires commented 7 months ago

Coverage report

Branches coverage not met for global: expected >=90%, but got 78.125%
St.:grey_question:
Category Percentage Covered / Total
🟒 Statements 95.08% 58/61
🟑 Branches 78.13% 25/32
🟒 Functions 95% 19/20
🟒 Lines 95% 57/60

Test suite run success

24 tests passing in 2 suites.

Report generated by πŸ§ͺjest coverage report action from 43deced9e7832ffa4c89b27e930d1e71ac975e50

baires commented 7 months ago

LGTM, feel free to reopen it πŸ₯‚

Wervice commented 7 months ago

Ok, I'll reopen it. Alexis Sgarbossa @.***> schrieb am Donnerstag, 18. Januar 2024 um 21:45:

LGTM, feel free to reopen it πŸ₯‚

β€” Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: @.***>

Wervice commented 7 months ago

I'm sorry for the discomfort. I reopened the post now, but GitHub said this: coverage / Coverage-report (pull_request_target) Failing after 50s wervice @.***> schrieb am Freitag, 19. Januar 2024 um 11:46 vorm.:

Ok, I'll reopen it. Alexis Sgarbossa @.***> schrieb am Donnerstag, 18. Januar 2024 um 21:45:

LGTM, feel free to reopen it πŸ₯‚

β€” Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: @.***>

baires commented 7 months ago

I think GH token associated with the action is expired, I will take a look tomorrow. LGTM

Wervice commented 7 months ago

I'm sorry for my late response. Thank you for approving the request.

Sicher versendet mit Proton Mail.

Alexis Sgarbossa @.***> schrieb am Freitag, 19. Januar 2024 um 16:38:

@baires approved this pull request.

β€” Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: @.***>