search

bairwell / middleware-cors

PSR-7 compatible middleware to provide CORs facilities.
MIT License
18 stars 7 forks source link

Implement PSR15? #9

Open Moln opened 6 years ago

Moln commented 6 years ago

Will implement PSR15 ?

rbairwell commented 6 years ago

Hi,

It's certainly on my list of things to add - which framework/library are you currently using which is PSR-15 compatible (just mainly so I can 100% check it is working correctly).

Moln commented 6 years ago

zendframework/zend-expressive-skeleton:^3.0.0rc4

rbairwell commented 6 years ago

Just so you know, I've spent most of today working on this and have got a proof of concept seeming to work in https://github.com/bairwell/middleware-cors/tree/psr15compatibility : adding

$aggregator = new ConfigAggregator([
    \Bairwell\MiddlewareCors\ZendFramework\ConfigProvider::class,

to config.php in a Zend Expressive project does seem to be including it, but I haven't managed to pass in settings or fix all the broken unit tests yet (I've also taken the chance to update dependencies and change a few other bits of code). It's still a work in progress, but should be done soon.