[trunk] [XEP-0045 XEP-0004] MUC configuration return a field with the same name 2 times

Hello,

While asking for the configuration data form to prosody's MUC service, the 
configuration return a data form with 2 times a field with 
var='muc#roomconfig_persistentroom', which violate XEP-0004 (section 3.2: "If 
the <field/> element type is anything other than "fixed" (see below), it MUST 
possess a 'var' attribute that uniquely identifies the field in the context of 
the form (if it is "fixed", it MAY possess a 'var' attribute)."), resulting in 
a impossibility to configure the room with some client.

Below you'll find a copy of the received stanza.

prosody version (trunk): f2a7ad099e01

---

incoming stanza

<iq id='H_92' type='result' to='goffi@necton3.int/SàT'
from='test@conference.necton3.int'><query
xmlns='http://jabber.org/protocol/muc#owner'><x type='form'
xmlns='jabber:x:data'><title>Configuration for
test@conference.necton3.int</title><instructions>Complete and submit this
form to configure the room.</instructions><field type='hidden'
var='FORM_TYPE'><value>http://jabber.org/protocol/muc#roomconfig</value></f
ield><field type='boolean' label='Make Room Publicly Searchable?'
var='muc#roomconfig_publicroom'><value>1</value></field><field
type='text-single' label='Maximum Number of History Messages Returned by
Room' var='muc#roomconfig_historylength'><value>20</value></field><field
type='text-single' label='Description'
var='muc#roomconfig_roomdesc'><value>ceci est la description de la
salle</value></field><field type='boolean' label='Allow Occupants to Change
Subject?' var='muc#roomconfig_changesubject'><value>1</value></field><field
type='text-single' label='Name'
var='muc#roomconfig_roomname'><value>testtouille</value></field><field
type='list-single' label='Who May Discover Real JIDs?'
var='muc#roomconfig_whois'><option label='Moderators
Only'><value>moderators</value></option><option
label='Anyone'><value>anyone</value></option><value>anyone</value></field><
field type='boolean' label='Make Room Persistent?'
var='muc#roomconfig_persistentroom'><value>1</value></field><field
type='boolean' label='Make Room Persistent?'
var='muc#roomconfig_persistentroom'><value>1</value></field><field
type='boolean' label='Notify users when their affiliation changes when they
are not in the room?' var='muc#roomconfig_affiliationnotify'/><field
type='boolean' label='Make Room Members-Only?'
var='muc#roomconfig_membersonly'/><field type='boolean' label='Make Room
Moderated?' var='muc#roomconfig_moderatedroom'/><field type='text-private'
label='Password'
var='muc#roomconfig_roomsecret'><value></value></field></x></query></iq>

Original issue reported on code.google.com by goffigof...@gmail.com on 17 Mar 2015 at 11:26

baiwyc119 / lxmppd

[trunk] [XEP-0045 XEP-0004] MUC configuration return a field with the same name 2 times #482