bajansen / home-assistant-frank_energie

Custom Component voor Home Assistant Frank Energie prijsinformatie
66 stars 18 forks source link

Support for Belgium? #90

Open wimvermoens opened 1 year ago

wimvermoens commented 1 year ago

In the media I saw that Frank Energie will come to the Belgian market. Is it possible to add support for this?

Thanks in advance! Wim

DCSBL commented 1 year ago

What kind of “support”? Is something not working at the moment?

wimvermoens commented 1 year ago

I am sorry but did not try this module, as if I am not a customer for Frank Energie at this moment. But I think you mean this is already possible to see the spot prices for Belgium, and to calculate the all-in price based on a postal code? Thank you for the very fast response btw.

Fockaert commented 12 months ago

Frank energie is now available in Belgium as well, not sure different prices/accounts will be applied between Netherlands and Belgium.

https://www.frankenergie.be/nl

HiDiHo01 commented 12 months ago

Frank energie is now available in Belgium as well, not sure different prices/accounts will be applied between Netherlands and Belgium.

https://www.frankenergie.be/nl

It should work the same as Belgium uses the same app as the Netherlands

PieterVO commented 11 months ago

Some aspects are different for Belgium (e.g. the queries). I've been working on BE support for the addon here and for the python sdk here. Currently I use it without account, as I wasn't able to get invoices/meter readings working yet (neither are they working in the Frank app). As soon as this is also covered, I can open a pull request. Prices for BE are working though and reflect the ones shown in the Frank app.

BliXem1 commented 11 months ago

@PieterVO, I'm going to Frank Energie (BE), if I choose the Current electricity price (All-in), this is VAT inclusive and other prices, right? :)

Update: I mean are these prices which are included here: https://cdn.sanity.io/files/8navd656/production-be/050567bdad8ec19408f0aab6814c964523e4918a.pdf, added within the all in price?

BliXem1 commented 11 months ago

@PieterVO And I can't login (Account Frank Energie) with your addon for now I see.

TimVanOnckelen commented 10 months ago

It seems that there are in fact differences in pricing. It may be a small fix because changing the header "x-country" to "BE" seems to be the parameter to receive belgian data.

FrederikVV commented 10 months ago

[BE customer] Indeed, noticed as well differences in pricing. Also received an error when trying to logon: Config entry 'xxxx@gmail.com' for frank_energie integration not ready yet: Site reference not provided for customer market prices (BE); Retrying in background

kurtdefeyter commented 10 months ago

@TimVanOnckelen may i ask you where you did change that ? Many thanks

snorrebot commented 9 months ago

[BE customer] Indeed, noticed as well differences in pricing. Also received an error when trying to logon: Config entry 'xxxx@gmail.com' for frank_energie integration not ready yet: Site reference not provided for customer market prices (BE); Retrying in background

I'm also encountering this error. Any news about a possible fix for the Belgians? Many thanks in advance!

thomas-svrts commented 9 months ago

@PieterVO whenever I login with your addon and sdk i get the following error:

File "/usr/local/lib/python3.11/site-packages/python_frank_energie/frank_energie.py", line 55, in _query else {"X-Country": self._country.value}, ^^^^^^^^^^^^^^^^^^^ AttributeError: 'str' object has no attribute 'value'

I am using a Belgian account.

iOlivier commented 8 months ago

I would love support for Belgian accounts 🤩

VincentVanTricht commented 8 months ago

Yeah, Please make it work for Belgium :-))

PieterVO commented 8 months ago

@PieterVO whenever I login with your addon and sdk i get the following error:

File "/usr/local/lib/python3.11/site-packages/python_frank_energie/frank_energie.py", line 55, in _query else {"X-Country": self._country.value}, ^^^^^^^^^^^^^^^^^^^ AttributeError: 'str' object has no attribute 'value'

I am using a Belgian account.

I made some changes to make it work. Please try this version.

thomas-svrts commented 8 months ago

Login works, but integration doesn't initialise. It is important to know that my contract only starts on Feb 1st, although login in frank energy app works fine.

I see now next message in the logs, repeated constantly:

2024-01-30 22:00:33.436 DEBUG (MainThread) [custom_components.frank_energie.coordinator] Fetching Frank Energie data
2024-01-30 22:00:35.628 DEBUG (MainThread) [custom_components.frank_energie.coordinator] Finished fetching Frank Energie coordinator data in 2.191 seconds (success: False)
thomas-svrts commented 8 months ago

I'm now fully onboarded as customer. But still same message in the logs:

2024-02-02 18:56:22.668 DEBUG (MainThread) [custom_components.frank_energie.coordinator] Fetching Frank Energie data
2024-02-02 18:56:24.074 DEBUG (MainThread) [custom_components.frank_energie.coordinator] Finished fetching Frank Energie coordinator data in 1.406 seconds (success: False)
2024-02-02 18:56:29.477 DEBUG (MainThread) [custom_components.frank_energie.coordinator] Fetching Frank Energie data
2024-02-02 18:56:30.728 DEBUG (MainThread) [custom_components.frank_energie.coordinator] Finished fetching Frank Energie coordinator data in 1.251 seconds (success: False)
2024-02-02 18:56:40.981 DEBUG (MainThread) [custom_components.frank_energie.coordinator] Fetching Frank Energie data

Maybe adding some more logging would be great.

HiDiHo01 commented 8 months ago

I think the app is broken because Frank made some changes to the API. Can someone confirm this?

Op vr 2 feb 2024 19:02 schreef thomas-svrts @.***>:

I'm now fully onboarded as customer. But still same message in the logs:

2024-02-02 18:56:22.668 DEBUG (MainThread) [custom_components.frank_energie.coordinator] Fetching Frank Energie data 2024-02-02 18:56:24.074 DEBUG (MainThread) [custom_components.frank_energie.coordinator] Finished fetching Frank Energie coordinator data in 1.406 seconds (success: False) 2024-02-02 18:56:29.477 DEBUG (MainThread) [custom_components.frank_energie.coordinator] Fetching Frank Energie data 2024-02-02 18:56:30.728 DEBUG (MainThread) [custom_components.frank_energie.coordinator] Finished fetching Frank Energie coordinator data in 1.251 seconds (success: False) 2024-02-02 18:56:40.981 DEBUG (MainThread) [custom_components.frank_energie.coordinator] Fetching Frank Energie data

— Reply to this email directly, view it on GitHub https://github.com/bajansen/home-assistant-frank_energie/issues/90#issuecomment-1924419732, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXDM263IWEAPGFYIZJWAIJLYRUS3VAVCNFSM6AAAAAA36EHRHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRUGQYTSNZTGI . You are receiving this because you commented.Message ID: @.***>