bajrangCoder / zed-scss

SCSS support for Zed
13 stars 4 forks source link

auto complete / suggestions don't work #5

Closed c0ff-prvt closed 6 months ago

c0ff-prvt commented 6 months ago

I am not sure if this is the correct repo to report this issue. As mentioned in this comment, the auto-complete/suggestions don't work. I don't know if this is related to Zed or this extension.

If this is the wrong place for the issue, I apologize for that and you can close my issue.

bajrangCoder commented 6 months ago

There is no dedicated language server available for SCSS. Therefore, many users suggest using the CSS language server for SCSS. The CSS language server is built into Zed. To enable it for SCSS, simply adjust the settings and add css language server inside scss mode.

jk-propeller commented 6 months ago

This makes sense, sry for the issue then^^

Im gonna try to find out how I can configure this in Zed. Did you ajusted the zed settings in this way (if yes can u share the part in config)?

bajrangCoder commented 6 months ago

This makes sense, sry for the issue then^^

Im gonna try to find out how I can configure this in Zed. Did you ajusted the zed settings in this way (if yes can u share the part in config)?

Soon I'm going to publish v0.0.3 which will come with css language server built-in. So, no need of any extra config

jk-propeller commented 6 months ago

Thanks for your work, this sounds great! Especially because I can't get the built-in VS Code CSS language server working in SCSS :/

Btw, I tried something like this (also in language_overrides):

  "languages": {
    "SCSS": {
      "language_servers": [
        "vscode-css-languge-server",
        "tailwindcss-language-server",
        "..."
      ]
    }
  },
bajrangCoder commented 6 months ago

Yes , it's not working because currently they have removed it.

So you can now only wait for the update to be merged.

jk-propeller commented 6 months ago

Thanks for the quick response! Thanks for the info. I'll wait for v0.0.3 of your extension. 👌

Should we leave this issue open until v0.0.3 is out? This may help others with the same issue as me to know what the current state is.

jk-propeller commented 6 months ago

Just saw that v0.0.3 is out. That was very soon, thanks for ur work! Its working now, this makes my workday today better^^

bajrangCoder commented 6 months ago

Just saw that v0.0.3 is out. That was very soon, thanks for ur work! Its working now, this makes my workday today better^^

Glad to hear! Now I'm going to close this issue.

marcolaux commented 6 months ago

It does not support auto complete for things like @include or suggestions from imported files.

marcolaux commented 6 months ago

auto complete also doesn't work for general CSS things while being inside of an @include

example:

  > .wrap {
    max-width: var(--width-big);
    display: flex;
    flex-direction: column;

    @include media(med) {
      padding: 0;
      flex-direction: row;
      // auto complete doesn't work in here
    }
  }
bajrangCoder commented 6 months ago

@marcolaux Yes, it doesn't show completion for external file (I'm working on it) But it works fine in @include block 👇

https://github.com/bajrangCoder/zed-scss/assets/71929976/0747647b-7848-4fd2-92ec-e4b12e8d65f3