search

bakano98 / pe

0 stars 0 forks source link

Error message is not informative enough #3

Open bakano98 opened 2 years ago

bakano98 commented 2 years ago

When attempting to edit to a phone number that already exists, this error message is shown:
image.png

While the customer indeed does already exist, it would be more helpful to specify why the editing actually failed. For example, if I wanted to edit 2 fields:

image.png

And they both already exist, I would not know which one is actually causing the problem

nus-pe-script commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unclear error message when editting someone to have the same phone number as another person in the contacts

image.png

Command: editc 1 p/99272758

This edits Alex Yeoh's phone number to be the same as Bernice Yu, but the error message does not reflect that, saying that "This customer already exists in trackBeau.", which is unclear, especially if more parameters are added into the edit command, it would be confusing to figure out which part of the command was incorrect.

[original: nus-cs2103-AY2122S2/pe-interim#2517] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for the report. It was stated in the UG that No 2 customers can have the same phone number or same email so the users can infer from this that the error message of This customer already exists in TrackBeau refers to there exists a customer with the same phone number or email in TrackBeau.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Even though you have stated in the UG that "No 2 customers can have the same phone number or same email", why would you make your users guess which one is the duplicate? It makes more sense for you to tell the user what the problem is, rather than them having to look for what the problem is.

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: I don't think bad error messages are a functionality bug rather than a feature flaw. The error message is not pertaining to the function, but rather a feature of the product.