bakano98 / pe

0 stars 0 forks source link

Able to add multiple appointments during an occupied timeslot #6

Open bakano98 opened 2 years ago

bakano98 commented 2 years ago

image.png

Expected: User should not be able to add more appointments for the same person when they are already "occupied" for that timeframe (in the screenshot, Alex Yeoh should be occupied from 10.30AM to 11.30AM)

Actual: You can add more.

Steps to reproduce:

  1. addb c/1 sev/1 st/10-10-2022 10:30
  2. addb c/1 sev/1 st/10-10-2022 10:31
  3. addb c/1 sev/1 st/10-10-2022 10:32
nus-se-script commented 2 years ago

Team's Response

We were expecting multiple bookings to be available as a customer can have different services during the same timeframe. However, having the option to choose the same service during the same timeframe is a flaw therefore we think that this should be low severity.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: For reference:
image.png

I disagree with lowering the severity because this can and will affect the normal operations of the product, which causes occasional inconvenience.

Let me give you a scenario: I am a user of this app, and I am unaware or forgot that an Alex Yeoh has a booking from 10.30am to 11.30am for a particular service Organic Radiance Facial

Suddenly, I remembered that Alex Yeoh wants a booking for a service, Organic Radiance Facial, and he says "Any time from 10am to 1pm is good". So, I decide that 11am would be a good timing, and assign Alex Yeoh to 11am to 12pm for the service Organic Radiance Facial.

But I forgot that I have actually added this booking for him already, from 10.30am to 11.30am! When the date comes closer, I check my appointments and then I realised there's two bookings for Alex Yeoh... so what do I do? Now, I have to call him and verify which one is a better timing for him, and have to forfeit one timeslot which causes me to lose business as well.

All this could have been prevented by adding checks, and it does indeed cause occasional inconvenience to the user. Hence, I don't think that the severity is a Low.

In any case, with the reasoning provided by the team, it solidifies my belief that this deserves a Medium severity due to a Feature Flaw. My justification is as such:
For customers who already have an appointment and want to have multiple services done during the same timeslot, those services should be appended onto the existing booking for that customer rather than creating a new Appointment object within the Bookings. This is much more convenient for the user to see and keep track of their customers as well.