search

bakano98 / pe

0 stars 0 forks source link

Unable to specify 24:00 as a time #9

Open bakano98 opened 2 years ago

bakano98 commented 2 years ago

When executing: editb 1 st/10-12-2021 24:00 or when adding any time with 24:00 supplied as the parameter, it throws an error message.

Expected: editb 1 sr/10-12-2021 24:00 sets the booking at index 1 to be at 11-12-2021, 12AM.
Actual: Does not allow adding.

There are no constraints specified for this, so 24:00 should be accepted as an input. Specifying 24:00 simply means "midnight for the next day", i.e. 24:00 of 10-10-2021 is 00:00 of 11-10-2021.

nus-pe-script commented 2 years ago

Team's Response

Thank you for the report. Midnight of the next day is actually 00:00 and not 24:00 in fact 24 is not a valid value for HH.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Sorry, I got 00:00 and 24:00 the other way round. Could not use Google during the PE.

Either way, 24:00 is considered to be a valid input:

image.png