search

bakape / hydron

media tagger and organizer
GNU Lesser General Public License v3.0
95 stars 9 forks source link

client, templates: Make image cutoff a little better by truncating text #48

Closed Chiiruno closed 5 years ago

Chiiruno commented 6 years ago

Fixes #47 Unfortunately, I don't think this is the only thing that needs to be done, we probably need a flex bar for the width so the image doesn't get cut off anyway, so we can just scroll to see the rest. Either that, or resize the image HTML to fit the left-side panel.

bakape commented 6 years ago

we probably need a flex bar for the width so the image doesn't get cut off anyway

Why? I'd think that max-width takes care of that.

Chiiruno commented 6 years ago

Because the image gets cut-off regardless.

bakape commented 6 years ago

Doesn't sound right. I'll investigate this later.

On 3 September 2018 at 01:29, チルノ notifications@github.com wrote:

Because the image gets cut-off regardless.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/bakape/hydron/pull/48#issuecomment-417964299, or mute the thread https://github.com/notifications/unsubscribe-auth/AHfPsAwhi_tTZIKov83pspfwLFWpS5Kmks5uXFvYgaJpZM4WWySW .

Chiiruno commented 6 years ago

Yup. Gonna move jshint to devDependencies too. No need for that to be in the main.

bakape commented 5 years ago

Works on my machine™. What was the problem with this again?

Chiiruno commented 5 years ago

I don't remember, if it comes up, I'll probably do another PR.