search

bakape / thumbnailer

Go media thumbnailer
MIT License
152 stars 36 forks source link

Printed errors #67

Closed artvel closed 4 years ago

artvel commented 4 years ago

Not sure how serious and helpful the printed errors are like:

[mjpeg @ 0x7fc70c680f80] unable to decode APP fields: Invalid data found when processing input
[mjpeg @ 0x7fc70c681880] unable to decode APP fields: Invalid data found when processing input
[mjpeg @ 0x7fc70c88e480] overread 8
[mjpeg @ 0x7fc70c680440] unable to decode APP fields: Invalid data found when processing input
[mjpeg @ 0x7fc70c6808c0] mjpeg: error decoding EXIF data
[mjpeg @ 0x7fc70c6808c0] No JPEG data found in image
[mjpeg @ 0x7fc70c67e000] mjpeg: error decoding EXIF data
[mjpeg @ 0x7fc70c67e000] No JPEG data found in image

One thing I know for sure is, they spam the log although a thumbnail was created most of the times.

I would suggest to only print these kind of errors when an err in go was returned by the process call, to help track the cause.

What do you think @bakape? Does that make any sense?

bakape commented 4 years ago

These are printed inside the FFmpeg libraries. IIRC I have fine-grained control over them.

On Wed, 8 Jul 2020 at 17:45, Artan Veliju notifications@github.com wrote:

Not sure how serious and helpful the printed errors are like:

[mjpeg @ 0x7fc70c680f80] unable to decode APP fields: Invalid data found when processing input [mjpeg @ 0x7fc70c681880] unable to decode APP fields: Invalid data found when processing input [mjpeg @ 0x7fc70c88e480] overread 8 [mjpeg @ 0x7fc70c680440] unable to decode APP fields: Invalid data found when processing input [mjpeg @ 0x7fc70c6808c0] mjpeg: error decoding EXIF data [mjpeg @ 0x7fc70c6808c0] No JPEG data found in image [mjpeg @ 0x7fc70c67e000] mjpeg: error decoding EXIF data [mjpeg @ 0x7fc70c67e000] No JPEG data found in image

One thing I know for sure is, they spam the log although a thumbnail was created most of the times.

I would suggest to only print these kind of errors when an err in go was returned by the process call, to help track the cause.

What do you think @bakape https://github.com/bakape? Does that make any sense?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bakape/thumbnailer/issues/67, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB347MG2X4CEBITGWJ4XVD3R2SA7DANCNFSM4OUUT27A .

bakape commented 4 years ago

On Thu, 9 Jul 2020 at 13:01, Janis Petersons bakape@gmail.com wrote:

These are printed inside the FFmpeg libraries. IIRC I have fine-grained control over them.

On Wed, 8 Jul 2020 at 17:45, Artan Veliju notifications@github.com wrote:

Not sure how serious and helpful the printed errors are like:

[mjpeg @ 0x7fc70c680f80] unable to decode APP fields: Invalid data found when processing input [mjpeg @ 0x7fc70c681880] unable to decode APP fields: Invalid data found when processing input [mjpeg @ 0x7fc70c88e480] overread 8 [mjpeg @ 0x7fc70c680440] unable to decode APP fields: Invalid data found when processing input [mjpeg @ 0x7fc70c6808c0] mjpeg: error decoding EXIF data [mjpeg @ 0x7fc70c6808c0] No JPEG data found in image [mjpeg @ 0x7fc70c67e000] mjpeg: error decoding EXIF data [mjpeg @ 0x7fc70c67e000] No JPEG data found in image

One thing I know for sure is, they spam the log although a thumbnail was created most of the times.

I would suggest to only print these kind of errors when an err in go was returned by the process call, to help track the cause.

What do you think @bakape https://github.com/bakape? Does that make any sense?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bakape/thumbnailer/issues/67, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB347MG2X4CEBITGWJ4XVD3R2SA7DANCNFSM4OUUT27A .