search

bakdata / aws-lambda-r-runtime

Serverless execution of R code on AWS Lambda
https://medium.com/bakdata/running-r-on-aws-lambda-9d40643551a6
MIT License
144 stars 53 forks source link

without-recommended-packages #46

Closed danielarantes closed 5 years ago

danielarantes commented 5 years ago

Firstly...thanks for this runtime and layer instructions!

I made a tiny modification to avoid installing the recommended packages and removing it afterwards.

It just adds --without-recommended-packages to the configure command to build R and I just commented out the loop that was removing the packages on runtime/build.sh.

Daniel

philipp94831 commented 5 years ago

Hi @danielarantes, thanks for your PR. I really like the option. However, the recommended layer breaks with this change. We need to install the packages in a similar fashion as for the awspack layer. Can you please add this to your PR? I can help if needed. Cheers

danielarantes commented 5 years ago

I made a change to the recommended build the same way you did for awspack. But the build failed in at least one of the tests. I'm not sure exactly what caused it.

philipp94831 commented 5 years ago

Hi @danielarantes, the build fails because the AWS credentials deployed on Travis are not available for PRs. The respective tests should have been disabled so I need to fix that in the future. Your PR looks good and I will merge it into develop. Thanks!