bakdata / ci-templates

Collection of reusable workflows and composite actions for Github
MIT License
4 stars 1 forks source link

Replace docker-build action in all workflows with official action #139

Closed yannick-roeder closed 8 months ago

yannick-roeder commented 1 year ago

Description

Initially we decided against the official docker-build-push action since it didn't seem to support building without pushing. Now there is an input push which can be set to false, so we can use this action for building and still rely on our custom tagging logic for pushing images build from Dockerfiles and Jib. We want to remove our docker-build action and replace it in every workflow with the docker-build-push action, because it offers more features.

Acceptance criteria

JakobEdding commented 1 year ago

Regarding tagging, there is also https://github.com/docker/metadata-action whose type=raw,value= seems to be quite flexible. Perhaps it's possible to do type=raw,value=pipeline-${{ github.run_id }}-git-{{sha}}?