search

bakdata / ci-templates

Collection of reusable workflows and composite actions for Github
MIT License
4 stars 1 forks source link

Create composite action to lint actions and workflows #66

Closed MichaelKora closed 1 year ago

MichaelKora commented 1 year ago

Fixes #15

disrupted commented 1 year ago

What is the goal of this PR? I think the linked issue https://github.com/bakdata/ci-templates/issues/15 is unrelated. Unfortunately it doesn't have a description. It is aimed at the actionlint workflow, specifically to convert https://github.com/bakdata/ci-templates/blob/aecaea688691daf63e85a17ee4419aa8a3b057d8/.github/workflows/lint.yaml#L16 to a composite action.

MichaelKora commented 1 year ago

@disrupted as far as i understood, we want a workflow that uses the helm-lint composite action. and thats what the PR does

disrupted commented 1 year ago

@disrupted as far as i understood, we want a workflow that uses the helm-lint composite action. and thats what the PR does

We need a composite action for actionlint. For Helm lint we already have the composite action https://github.com/bakdata/ci-templates/tree/main/actions/helm-lint

philipp94831 commented 1 year ago

Shouldn't this action be used in a workflow in this repo?

@MichaelKora What about this?

philipp94831 commented 1 year ago

Checks are failing