search

bakdata / ci-templates

Collection of reusable workflows and composite actions for Github
MIT License
4 stars 1 forks source link

Change output method #67

Closed MichaelKora closed 1 year ago

MichaelKora commented 1 year ago

Fixes #63 Fixes #34 I removed the scripts dir. Since the version v1.13.2 was working just fine, i am not seeing any reason why we should create an extra python file.

I solved the initial issue using this approach.

disrupted commented 1 year ago

if the Python script file is not used anymore, please delete it.

disrupted commented 1 year ago

Please redo the merge, it seems that you overwritten your changes.

raminqaf commented 1 year ago

You mentioned that version v1.13.2 was working just fine. That is true. Because back then, we were using the set-output, which is now deprecated and replaced with the environment files. The reason I moved the python code to the script was that the new environment files wrap the python code into double quotes and I was skeptical if this might break the CI template. Moreover, the code is hard to read and understand, and putting it in a file with a proper name (like get-version) describes its functionality. But it seems that the runner cannot find the file. So it is okay that you fixed it! Thanks! 😄