search

bakdata / ci-templates

Collection of reusable workflows and composite actions for Github
MIT License
4 stars 1 forks source link

Update Poetry to 1.3.2 #74

Closed disrupted closed 1 year ago

disrupted commented 1 year ago

Why do we need to update the version? Isn't the version customizable when using the workflows/actions?

I would prefer setting a new default, because Poetry has a new lock file format. Otherwise we have to overwrite Poetry version in a lot of places.

philipp94831 commented 1 year ago

Why do we need to update the version? Isn't the version customizable when using the workflows/actions?

I would prefer setting a new default, because Poetry has a new lock file format. Otherwise we have to overwrite Poetry version in a lot of places.

Hm, I don't think this is worth a PR. Poetry version should be pinned in other Repos anyways and you also would need to bump the workflow version in those repos anyways

disrupted commented 1 year ago

Hm, I don't think this is worth a PR. Poetry version should be pinned in other Repos anyways and you also would need to bump the workflow version in those repos anyways

ok, you're right