search

bakdata / kafka-error-handling

A library for error handling in Kafka Streams.
MIT License
18 stars 3 forks source link

Use wall-clock time for dead letter record #28

Closed torbsto closed 4 months ago

torbsto commented 4 months ago

The written dead-letter now has the wall-clock time as its record's timestamp. Because the original timestamp would be lost otherwise, there is a new field in the respective dead-letter models called timestamp. To maintain backwards compatibility, it is nullable, but always set starting from this version.

philipp94831 commented 4 months ago

Can you also update https://github.com/bakdata/kafka-dead-letter-analyzer?

mkcode92 commented 4 months ago

Code looks good to me, but maybe we can call the new field more specificly inputTimestamp or initialTimestamp?

philipp94831 commented 4 months ago

Code looks good to me, but maybe we can call the new field more specificly inputTimestamp or initialTimestamp?

To make it consinstent with input_value, input_timestamp makes sense. But I also like just timestamp

torbsto commented 4 months ago

I changed it to input_timestamp