search

bakdata / kpops

Deploy Kafka pipelines to Kubernetes
https://bakdata.github.io/kpops
MIT License
12 stars 1 forks source link

Variable substitution does not work on Windows #102

Closed philipp94831 closed 1 year ago

philipp94831 commented 1 year ago

We use os.environ in order to substitute internal variables such as pipeline_name: https://github.com/bakdata/kpops/blob/8f5e1bdc7f4ddf13e633259908fd1d9bcc4b34e0/kpops/pipeline_generator/pipeline.py#L90. However, when calling dict(os.environ), Windows returns a dictionary containing {"PIPELINE_NAME": ...}. Therefore, substitution does not work. We should find another way to do the substitution. In my opinion, we should not add our internal variables to os.environ but rather add os.environ to our dictionary of variables.

sujuka99 commented 1 year ago

Why that happens

irux commented 1 year ago

I can take a look in to it and try to solve this. I mainly use windows , so I think this helps. Moreover I will try to take a look if everything in windows works as expected :)

irux commented 1 year ago

so, should I lower case it and do that quick fix? or do you propose to make big shared dict that saves all the vars ? @philipp94831

philipp94831 commented 1 year ago

We should create our own dict