search

bakdata / kpops

Deploy Kafka pipelines to Kubernetes
https://bakdata.github.io/kpops
MIT License
12 stars 1 forks source link

Change substitution variables separator to `.` #388

Closed sujuka99 closed 9 months ago

raminqaf commented 9 months ago

Why do we need to change the separator? Do we need this because of this? https://github.com/bakdata/kpops/pull/384/files#diff-a7e11ead0d843c3b75b7427119e68b95eb41970f919eff2cf96e1111ff485822R80 This is a breaking change and a confusing and error-prone way of introducing substitution variables. Having two _ is not an intuitive way of defining variables.

sujuka99 commented 9 months ago

Closing as it seems to be inconvenient for the users

sujuka99 commented 9 months ago

Reopening, the delimiter will be a dot instead.