search

bakdata / kpops

Deploy Kafka pipelines to Kubernetes
https://bakdata.github.io/kpops
MIT License
12 stars 1 forks source link

KafkaConnectorConfig.name should be optional #412

Closed sujuka99 closed 6 months ago

sujuka99 commented 6 months ago

We require the user to set the name in KafkaConnectorConfig, but it's then overwritten. The validator seems to accept that KafkaConnectorConfig.name could be None, so we should just make KafkaConnectorConfig.name optional.

disrupted commented 6 months ago

I believe that's not a good idea, name is a required attribute for Kafka Connector config. We do not require regular KPOps users to set it manually. For added convenience, KPOps takes care of it automatically so you don't have to repeat it in your YAML. Only if you're instantiating the class directly, language tools will show an error for the missing attribute, which is to be expected.