producer chart: job/cronjob switch

bakdata / streams-bootstrap

Utility functions and base classes for Kafka Streams applications

MIT License

29 stars 3 forks source link

producer chart: job/cronjob switch #110

Closed mkcode92 closed 3 years ago

mkcode92 commented 3 years ago

make producer-app deployable as job
problem: when switching between job/cronjob a lot of shared config is needed in a different path (spec.template vs spec.jobTemplate.spec.template)
this block is now separated as podTemplate

yannick-roeder commented 3 years ago

LGTM, did you test it?

torbsto commented 3 years ago

@VictorKuenstler @philipp94831 This is a fix for the changes introduced by #108. I've mistakenly assumed that Job and CronJob have the same spec besides schedule. Obviously, the changes in this PR are more complex than those in #108. I still think it's worth to have it.

@mkcode92 I think you also have to update the producer-app chart according to the steps listed here: https://github.com/bakdata/streams-bootstrap/tree/master/charts#development

yannick-roeder commented 3 years ago

@mkcode92 I think you also have to update the producer-app chart according to the steps listed here: https://github.com/bakdata/streams-bootstrap/tree/master/charts#development

True, thanks @torbsto

mkcode92 commented 3 years ago

LGTM, did you test it?

Yes, both should work!