bakdata / streams-bootstrap

Utility functions and base classes for Kafka Streams applications
MIT License
29 stars 3 forks source link

Clean schemas of pseudo topics created when performing a foreign key join #113

Closed philipp94831 closed 3 years ago

philipp94831 commented 3 years ago

Fixes #112

philipp94831 commented 3 years ago

While we are at it, I guess isInternalTopic() also needs an update. It looks to me like getExternalSinkTopics() returns the pseudo topics

But the isInternalTopic() and isExternalTopic() method is only applied to the nodes directly as far as I can see and I generate the topics afterwards

philipp94831 commented 3 years ago

While we are at it, I guess isInternalTopic() also needs an update. It looks to me like getExternalSinkTopics() returns the pseudo topics

Also in the test I wrote, the getExternalSinkTopics() only returns output