bakercp / PacketSerial

An Arduino Library that facilitates packet-based serial communication using COBS or SLIP encoding.
http://bakercp.github.io/PacketSerial/
MIT License
280 stars 59 forks source link

Supporting the NO_GLOBAL_SERIAL global definition #30

Open leifclaesson opened 2 years ago

leifclaesson commented 2 years ago

NO_GLOBAL_SERIAL

..is a global definition on the ESP32 Arduino platform which skips defining the Serial, Serial1 and Serial2 objects, leaving the user free to define these themselves. This is a great way of ensuring no other library uses a Serial port for anything we don't want it to, as it immediately generates a compile error.

Unfortunately the legacy begin() function is one of those functions that reference the global Serial object. So, I forked and added an #if defined(NO_GLOBAL_SERIAL) block inside the legacy begin() function so that PacketSerial is aware of this flag and does not try to link against the Serial object that doesn't exist. That's the only change I've made. The library itself works beautifully, very useful, thank you for making it!