search

bakercp / ofxHTTP

A suite of HTTP tools, including clients and servers for openFrameworks.
MIT License
110 stars 37 forks source link

example_basic_post_server - File upload corrupts uploaded File #27

Closed 0Kraft closed 9 years ago

0Kraft commented 9 years ago

Hi, File upload process is working but this error occurs during the upload: PostRouteFileHandler::handlePart: No filename in header . After the upload, the file does exist in the uploads directory, but it is corrupted. Tried unsuccesfully with jpeg, gif, zip and epub. with *.cpp files, there's no problem. In Case of the other files, it's not possible to open/work with the uploaded File. I noticed, that the filesize grows with the upload. (about some bytes)!?

Win7 + openFrameworks 0.8.4 + WinCB

0Kraft commented 9 years ago

I did a EOL-Conversion of the file from Macintosh to Unix. Now, filesizes of the files are identical, also I can't see any differences of the files in a hex-editor!? But still, files are corrupted.

0Kraft commented 9 years ago

In PostRouteFileHandler.cpp , i changed line 102 from

ofFile file(newFilename, ofFile::WriteOnly);

to

ofFile file(newFilename, ofFile::WriteOnly,true);

now it works! this sets the ofFile to binarymode. Is this a win-specific issue?

bakercp commented 9 years ago

It definitely sounds like it's windows-related. OfxHTTP hasn't been tested as heavily on Windows. Thanks for investigating. Would you mind submitting a pull request with your fixes?

On Tue, Feb 17, 2015, 7:02 AM doktorsuarez notifications@github.com wrote:

In PostRouteFileHandler.cpp , i changed line 102 from

ofFile file(newFilename, ofFile::WriteOnly);

to

ofFile file(newFilename, ofFile::WriteOnly,true);

now it works! this sets the ofFile to binarymode. Is this a win-specific issue?

— Reply to this email directly or view it on GitHub https://github.com/bakercp/ofxHTTP/issues/27#issuecomment-74664043.

0Kraft commented 9 years ago

Yes I will do that. Have to do some github-homework first, never submitted a pull request before.